[begin]: event_factory should cancel Close context in case of reselect #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eselect option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1519 +/- ##
=======================================
Coverage ? 67.02%
=======================================
Files ? 257
Lines ? 12257
Branches ? 0
=======================================
Hits ? 8215
Misses ? 3531
Partials ? 511 ☔ View full report in Codecov by Sentry. |
denis-tingaikin
requested review from
denis-tingaikin,
dualBreath,
d-uzlov,
NikitaSkrynnik and
edwarnicke
dualBreath
approved these changes
Oct 11, 2023
| @@ -101,13 +101,13 @@ func (f *eventFactoryClient) Request(opts ...Option) <-chan error { | |||
| request := f.request.Clone() | |||
| if o.reselect { | |||
| ctx, cancel := f.ctxFunc() | |||
| defer cancel() | |||
| _, _ = f.client.Close(ctx, request.GetConnection(), f.opts...) | |||
There was a problem hiding this comment.
LGTM,
ran the test on my side, works fine
Just a small question about the source of the issue: Am I correct in understanding that the original problem occurs because the cancel() for Request was run before the cancel() for Close, because they both use the defer directive?
There was a problem hiding this comment.
Not really. Close can use the context somewhere in its goroutine.
And this goroutine will be alive as long as this context is alive. But after the parent Close is completed, this is unnecessary and even dangerous - the goroutine can use the same data as the subsequent Request.
Therefore, before the Request, we need to complete Close call (including its goroutines)
There was a problem hiding this comment.
Great, thanks for explanation!
d-uzlov
approved these changes
Oct 16, 2023
denis-tingaikin
approved these changes
Oct 16, 2023
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Oct 16, 2023
…k@main PR link: networkservicemesh/sdk#1519 Commit: 836a51c Author: Artem Glazychev Date: 2023-10-16 16:32:00 +0700 Message: - event_factory should cancel Close context before Request in case of reselect option (#1519) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Oct 16, 2023
…k@main PR link: networkservicemesh/sdk#1519 Commit: 836a51c Author: Artem Glazychev Date: 2023-10-16 16:32:00 +0700 Message: - event_factory should cancel Close context before Request in case of reselect option (#1519) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-csi-driver
that referenced
this pull request
Oct 16, 2023
…k@main PR link: networkservicemesh/sdk#1519 Commit: 836a51c Author: Artem Glazychev Date: 2023-10-16 16:32:00 +0700 Message: - event_factory should cancel Close context before Request in case of reselect option (#1519) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Oct 16, 2023
…k@main PR link: networkservicemesh/sdk#1519 Commit: 836a51c Author: Artem Glazychev Date: 2023-10-16 16:32:00 +0700 Message: - event_factory should cancel Close context before Request in case of reselect option (#1519) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Oct 16, 2023
…k@main PR link: networkservicemesh/sdk#1519 Commit: 836a51c Author: Artem Glazychev Date: 2023-10-16 16:32:00 +0700 Message: - event_factory should cancel Close context before Request in case of reselect option (#1519) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Oct 16, 2023
…k@main PR link: networkservicemesh/sdk#1519 Commit: 836a51c Author: Artem Glazychev Date: 2023-10-16 16:32:00 +0700 Message: - event_factory should cancel Close context before Request in case of reselect option (#1519) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Oct 16, 2023
…k@main PR link: networkservicemesh/sdk#1519 Commit: 836a51c Author: Artem Glazychev Date: 2023-10-16 16:32:00 +0700 Message: - event_factory should cancel Close context before Request in case of reselect option (#1519) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Oct 16, 2023
…k@main PR link: networkservicemesh/sdk#1519 Commit: 836a51c Author: Artem Glazychev Date: 2023-10-16 16:32:00 +0700 Message: - event_factory should cancel Close context before Request in case of reselect option (#1519) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Oct 16, 2023
…k@main PR link: networkservicemesh/sdk#1519 Commit: 836a51c Author: Artem Glazychev Date: 2023-10-16 16:32:00 +0700 Message: - event_factory should cancel Close context before Request in case of reselect option (#1519) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Oct 16, 2023
…k@main PR link: networkservicemesh/sdk#1519 Commit: 836a51c Author: Artem Glazychev Date: 2023-10-16 16:32:00 +0700 Message: - event_factory should cancel Close context before Request in case of reselect option (#1519) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Oct 16, 2023
…k@main PR link: networkservicemesh/sdk#1519 Commit: 836a51c Author: Artem Glazychev Date: 2023-10-16 16:32:00 +0700 Message: - event_factory should cancel Close context before Request in case of reselect option (#1519) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Oct 16, 2023
…k@main PR link: networkservicemesh/sdk#1519 Commit: 836a51c Author: Artem Glazychev Date: 2023-10-16 16:32:00 +0700 Message: - event_factory should cancel Close context before Request in case of reselect option (#1519) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Oct 16, 2023
…k@main PR link: networkservicemesh/sdk#1519 Commit: 836a51c Author: Artem Glazychev Date: 2023-10-16 16:32:00 +0700 Message: - event_factory should cancel Close context before Request in case of reselect option (#1519) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Oct 16, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Oct 16, 2023
…k@main PR link: networkservicemesh/sdk#1519 Commit: 836a51c Author: Artem Glazychev Date: 2023-10-16 16:32:00 +0700 Message: - event_factory should cancel Close context before Request in case of reselect option (#1519) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chain elements in Closes can rely on the context and its timeout. Therefore, after the operation is completed, the context must be canceled.
Issue link
How Has This Been Tested?
Types of changes